Do not pass the -cl-std option to kernel builds#342
Open
zwets wants to merge 1 commit intoclMathLibraries:developfrom
Open
Do not pass the -cl-std option to kernel builds#342zwets wants to merge 1 commit intoclMathLibraries:developfrom
zwets wants to merge 1 commit intoclMathLibraries:developfrom
Conversation
- Resolves the abort in xgemm.cc:244 for OpenCL 1.1 devices
This was referenced Feb 20, 2019
Author
|
Created issue #343 to attach this PR to - yes I'm going the wrong way around :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves the oft-reported error:
This abort occurs after a
clBuildProgram()failure inmakeGemmKernel(). Inconveniently, the subsequent calls toclGetProgramBuildInfo()return an empty build log, which made this bug hard to track down.It turns out to be pretty simple: clBLAS passes build option
-cl-std="CL1.2"toclBuildProgram(). According to its man page, this means that the OpenCL implementation will immediately fail the build if the target device is OpenCL 1.0 or 1.1. (Would've been nice if they'd at least report this in the build log ... .)However, the
manpage also mentions thatand since we have a handle to the device at that point, this is precisely what we want.
I've tested against multiple OpenCL 1.1 and 1.2 backends, and it works like a charm. Best thing is that I can finally run clBLAS (and ArrayFire) on my somewhat older Radeon GPU.